Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated WebView2 DLLs to v1.0.2592.51 #2764

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

t-arn
Copy link
Contributor

@t-arn t-arn commented Aug 13, 2024

This PR updates the Winforms WebView2 DLLs to the current version 1.0.2592.51

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@t-arn
Copy link
Contributor Author

t-arn commented Aug 13, 2024

@freakboy3742 Please review this PR.
Regarding the MotW issue: I was a bit concerned that all developers using the new DLLs would have to set the MotW manually. But this does not seem to be case: I created the PR on my home PC and fetched/pulled the repo later on my office PC. And the WebView example worked with the new DLLs without setting the MotW manually :-)

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of doc-related comments inline, which I can fix. Thanks for the update!

changes/2764.misc.rst Outdated Show resolved Hide resolved
winforms/src/toga_winforms/libs/WebView2/README.md Outdated Show resolved Hide resolved
@freakboy3742
Copy link
Member

@t-arn On a side note - with changes that involve updating binaries, it's easier if they binaries aren't included in the PR, because not only do I have to validate that they work, but I also have to validate that they are the original binaries (i.e., that you haven't made a modification to the original sources). I can't do that without... downloading the original binaries :-)

If this might need to be updated regularly, it might be worth adding a script to automate the update process so that it's easy for me to generate a commit that has the updated binaries, rather than needing to manually audit the content of a commit.

@freakboy3742 freakboy3742 merged commit 3236d48 into beeware:main Aug 14, 2024
35 checks passed
@t-arn t-arn deleted the webview2_dlls branch August 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants