-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Gtk about dialog is destroyed #2812
Conversation
- If the About Dialog's X button was clicked, a TypeError for the number of arguments for _close_about was thrown - Now, an arbitrary number of positional arguments is accepted; it should be noted that pressing Escape does not send an extra pos arg...
aa6572d
to
2256ba9
Compare
CI testbed failure, fyi:
|
hmm...thinking out loud...i guess this highlights that the testbed doesn't exercise some of the native callbacks... Although, I'm also not sure how the testbed would simulate clicking the X button... |
Yeah - both the Windows and GTK mapviews are prone to this one. As best as I can work out, it's to do with Github Actions network being flakier than a pie crust. #2632 is the error for Winforms; I've added a note to clarify that it's occasionally a problem on GTK as well.
I'm guessing the best we'd be able to do is emit a GTK event for a window close. It's also worth noting why this fell through the cracks - on both of my Linux test desktops (Ubuntu default and Cinnamon), dialogs don't have X buttons. You can hit escape, or one of the "actual" buttons... but the dialogs are otherwise without any window decorations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't replicate this locally, but the change (and the way the bug would manifest) makes sense if you've got a GTK desktop theme that has close buttons on dialogs.
Changes
TypeError
for the number of arguments for_close_about()
was thrownPR Checklist: