Set App.app to initial value of None to avoid AttributeError in teardown #2918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the entire core test suite completes successfully. But at least one test (and probably others), when run individually, fail. Running
tests/style/pack/layout/test_rtl.py
by itself gets six instances of this:This is fine if a previous test has created an app instance, which is why it only fails in isolation. Changing it to a
hasattr
check fixes it, but then it still needs an additional truthiness orNone
check to avoid failingtest_window_created_without_app
, which setsApp.app
toNone
. At that point, why not just setNone
as the initial value in the class definition? It makes semantic sense for it to beNone
if there's no running app.PR Checklist: