Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache decoded toga color on gtk #3117

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

proneon267
Copy link
Contributor

Originally identified in #2484. However, since these changes are not directly related to #2484, so I have separated these changes from that PR.

This PR caches the decoded toga color on gtk, and also includes a minor cleanup.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@proneon267
Copy link
Contributor Author

proneon267 commented Jan 23, 2025

The webview test failures on windows & iOS are unrelated.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor tweak to the release note, but otherwise this makes sense.

changes/3117.misc.rst Outdated Show resolved Hide resolved
@freakboy3742 freakboy3742 merged commit e400294 into beeware:main Jan 24, 2025
41 checks passed
@proneon267 proneon267 deleted the gtk_cache_decoded_color branch January 26, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants