Implemented DPI process bug fix #717

everettraven · 2019-08-14T02:58:12Z

Changed the app.py create method for toga_winforms to check the current OS Version and build number to make sure we are using the most up to date DPI setting API for the user. Came across this issue when updating windows to the 1903 update (Build #: 18362)

PR Checklist:

All new features have been tested
All new features have been documented
I have read the CONTRIBUTING.md file
I will abide by the code of conduct

brutusthebee · 2019-08-14T02:58:47Z

src/winforms/toga_winforms/app.py

+            shcore.SetProcessDpiAwareness(True)
+        elif win_version >= 10 and win_build >= 15063:
+            user32.SetProcessDpiAwarenessContext(True)
+


At column 1: (W293) blank line contains whitespace

freakboy3742

Looks good (and works for my testing); a couple of minor tweaks inline.

freakboy3742 · 2019-08-14T03:16:25Z

src/winforms/toga_winforms/libs.py

 win_version = Environment.OSVersion.Version.Major
+win_build = Environment.OSVersion.Version.Build


This is a really small thing, but could we change win_version to be Environment.OSVersion.Version, and then get access to all the structure?

Went ahead and changed it to that.

freakboy3742 · 2019-08-14T03:17:08Z

src/winforms/toga_winforms/app.py

            user32.SetProcessDPIAware(True)
+        elif win_version >= 8 and win_build < 15063:


Are you able to provide any reference to documentation for why these magic numbers exist? An inline docstring will help explain the magic to whoever comes along later.

Actually - this specific check looks a little off - a windows 8 build with a high build number will break on this one.

You are correct that this check is wrong as the windows 8 major version number is actually a 6 and not an 8. In regards to build number it should only pull the update build number, which for Windows 8 the highest build number is 9600. I will fix this tomorrow when I have the chance. Source for information: https://www.lifewire.com/windows-version-numbers-2625171

I went ahead and implemented much better checks and loads of comments documenting what is what and why.

brutusthebee · 2019-08-15T02:37:58Z

src/winforms/toga_winforms/app.py

@@ -21,8 +21,23 @@ def __init__(self, interface):
    def create(self):
        self.native = WinForms.Application

-        if win_version >= 6:
-            user32.SetProcessDPIAware(True)
+        # Check the version of windows and make sure we are setting the DPI mode 


At column 81: (W291) trailing whitespace

brutusthebee · 2019-08-15T02:37:58Z

src/winforms/toga_winforms/app.py

+        # Windows Versioning Check Sources : https://www.lifewire.com/windows-version-numbers-2625171
+        # and https://docs.microsoft.com/en-us/windows/release-information/
+        if win_version.Major >= 6:  # Checks for Windows Vista or later
+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use 


At column 89: (W291) trailing whitespace

brutusthebee · 2019-08-15T02:37:59Z

src/winforms/toga_winforms/app.py

+        if win_version.Major >= 6:  # Checks for Windows Vista or later
+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use 
+            # SetProcessDpiAwareness(True)
+            if (win_version.Major == 6 and win_version.Minor == 3) or (win_version.Major == 10 and win_version.Build < 15063): 


At column 120: (E501) line too long (126 > 119 characters)

brutusthebee · 2019-08-15T02:38:00Z

src/winforms/toga_winforms/app.py

+        if win_version.Major >= 6:  # Checks for Windows Vista or later
+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use 
+            # SetProcessDpiAwareness(True)
+            if (win_version.Major == 6 and win_version.Minor == 3) or (win_version.Major == 10 and win_version.Build < 15063): 


At column 127: (W291) trailing whitespace

brutusthebee · 2019-08-15T02:38:01Z

src/winforms/toga_winforms/app.py

+            # SetProcessDpiAwareness(True)
+            if (win_version.Major == 6 and win_version.Minor == 3) or (win_version.Major == 10 and win_version.Build < 15063): 
+                shcore.SetProcessDpiAwareness(True)
+            # Represents Windows 10 Build 1703 and beyond which should use 


At column 75: (W291) trailing whitespace

brutusthebee · 2019-08-15T02:42:41Z

src/winforms/toga_winforms/app.py

+        if win_version.Major >= 6:  # Checks for Windows Vista or later
+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use
+            # SetProcessDpiAwareness(True)
+            if ((win_version.Major == 6 and win_version.Minor == 3) or 


At column 71: (W291) trailing whitespace

brutusthebee · 2019-08-15T02:42:42Z

src/winforms/toga_winforms/app.py

+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use
+            # SetProcessDpiAwareness(True)
+            if ((win_version.Major == 6 and win_version.Minor == 3) or 
+                (win_version.Major == 10 and win_version.Build < 15063)): 


At column 5: (E129) visually indented line with same indent as next logical line

brutusthebee · 2019-08-15T02:42:42Z

src/winforms/toga_winforms/app.py

+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use
+            # SetProcessDpiAwareness(True)
+            if ((win_version.Major == 6 and win_version.Minor == 3) or 
+                (win_version.Major == 10 and win_version.Build < 15063)): 


At column 74: (W291) trailing whitespace

brutusthebee · 2019-08-15T02:45:10Z

src/winforms/toga_winforms/app.py

+        # with the most up to date API
+        # Windows Versioning Check Sources : https://www.lifewire.com/windows-version-numbers-2625171
+        # and https://docs.microsoft.com/en-us/windows/release-information/
+        if win_version.Major >= 6: # Checks for Windows Vista or later


At column 35: (E261) at least two spaces before inline comment

brutusthebee · 2019-08-15T02:45:11Z

src/winforms/toga_winforms/app.py

+        if win_version.Major >= 6: # Checks for Windows Vista or later
+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use
+            # SetProcessDpiAwareness(True)
+            if ((win_version.Major == 6 and win_version.Minor == 3) or 


At column 71: (W291) trailing whitespace

brutusthebee · 2019-08-15T02:45:12Z

src/winforms/toga_winforms/app.py

+            # Represents Windows 8.1 up to Windows 10 before Build 1703 which should use
+            # SetProcessDpiAwareness(True)
+            if ((win_version.Major == 6 and win_version.Minor == 3) or 
+            (win_version.Major == 10 and win_version.Build < 15063)):


At column 13: (E128) continuation line under-indented for visual indent

freakboy3742

Awesome - Nicely done, and thanks for the contribution!

If you're still in this DPI hole, you might want to investigate why the font sizes in tutorial1 aren't adapting to DPI sizing... but that's not related to this patch.

Implemented DPI process bug fix

37dbd4f

brutusthebee reviewed Aug 14, 2019

View reviewed changes

fixed whitespace issue on line 30

4862005

freakboy3742 requested changes Aug 14, 2019

View reviewed changes

Added detailed comments. Better checks for OS

8ce41ec

brutusthebee reviewed Aug 15, 2019

View reviewed changes

pylint error fixes

c511f83

brutusthebee reviewed Aug 15, 2019

View reviewed changes

pylint error fix 2

98b66be

brutusthebee reviewed Aug 15, 2019

View reviewed changes

pylint error fix #3

9fa7425

freakboy3742 approved these changes Aug 15, 2019

View reviewed changes

freakboy3742 merged commit 510ec81 into beeware:master Aug 15, 2019

freakboy3742 mentioned this pull request Aug 22, 2019

alueError : Procedure probably called with too many arguments (4 bytes in excess) in example #726

Closed

13 tasks

mhsmith mentioned this pull request Sep 25, 2023

WinForms DPI scaling will look blurry for most users #2135

Closed

mhsmith mentioned this pull request Nov 8, 2023

Text fuzzy on Windows with per-monitor scaling #1004

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented DPI process bug fix #717

Implemented DPI process bug fix #717

everettraven commented Aug 14, 2019

brutusthebee Aug 14, 2019

freakboy3742 left a comment

freakboy3742 Aug 14, 2019

everettraven Aug 15, 2019

freakboy3742 Aug 14, 2019

freakboy3742 Aug 14, 2019

everettraven Aug 14, 2019

everettraven Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

brutusthebee Aug 15, 2019

freakboy3742 left a comment

		win_version = Environment.OSVersion.Version.Major
		win_build = Environment.OSVersion.Version.Build

		user32.SetProcessDPIAware(True)
		elif win_version >= 8 and win_build < 15063:

Implemented DPI process bug fix #717

Implemented DPI process bug fix #717

Conversation

everettraven commented Aug 14, 2019

PR Checklist:

Choose a reason for hiding this comment

freakboy3742 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

freakboy3742 left a comment

Choose a reason for hiding this comment