Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional args for chromium #34

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Additional args for chromium #34

merged 2 commits into from
Nov 6, 2023

Conversation

turbo124
Copy link
Collaborator

This adds a CLI option

I believe the change came about due to changes in switches

--headless=new and --headless=old 
=new --no-pdf-header-footer 
=old --print-to-pdf-no-header

Adding this flag is backward compatible from tests.

beganovich
beganovich approved these changes Nov 6, 2023
View reviewed changes
Copy link
Owner

@beganovich beganovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@beganovich beganovich merged commit afb188d into beganovich:master Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beganovich beganovich beganovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbo124 @beganovich