Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to modify the django runner class #125

Closed
wants to merge 2 commits into from
Closed

Adds ability to modify the django runner class #125

wants to merge 2 commits into from

Conversation

kingbuzzman
Copy link
Contributor

No description provided.

@bittner
Copy link
Member

bittner commented Dec 24, 2021

@kingbuzzman, can you explain the motivation in the PR body, also addressing the relation to PR #100, please?`And rebase your feature branch, so that the PR can be merged. Thank you!

EDIT Also, is this an alternative solution to #123? Will it make that PR obsolete?

@kingbuzzman
Copy link
Contributor Author

kingbuzzman commented Jan 3, 2022

@bittner thanks for your reply. I was looking for your input over at the issue

can you explain the motivation in the PR body, also addressing the relation to PR #100, please?

Adds the ability to add a custom Django facing TestRunner, this is different from #100 that changed the behave's TestRunner -- two different test cases.

Also, is this an alternative solution to #123? Will it make that PR obsolete?

Yes, and yes?? Depending on which solution you prefer; I personally have an issue with #123.. I don't know if you do too. If @rodrigondec changes his approach to be more in line with how this is normally done, I have no issue supporting #123

@bittner
Copy link
Member

bittner commented Jan 8, 2022

@kingbuzzman Please don't forget to rebase your branch. There are conflicts which don't allow me to merge your changes.

@kingbuzzman
Copy link
Contributor Author

kingbuzzman commented Jan 8, 2022

I deleted the fork a while back, i have since re-forked it, but i have an issue that the branch is detached, i created a new PR #130

@kingbuzzman kingbuzzman closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants