Skip to content

Commit

Permalink
module/zfs: remove zfs_zevent_console and zfs_zevent_cols
Browse files Browse the repository at this point in the history
zfs_zevent_console committed multiple printk()s per line without
properly continuing them ‒ a single event could easily be fragmented
across over thirty lines, making it useless for direct application

zfs_zevent_cols exists purely to wrap the output from zfs_zevent_console

The niche this was supposed to fill can be better served by something
akin to the all-syslog ZEDLET

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#7082 
Closes openzfs#11996
  • Loading branch information
nabijaczleweli authored and behlendorf committed May 28, 2021
1 parent cb2e336 commit 1cb517a
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 403 deletions.
1 change: 0 additions & 1 deletion include/os/freebsd/spl/sys/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ KERNEL_H = \
ccompile.h \
cmn_err.h \
condvar.h \
console.h \
cred.h \
ctype.h \
debug.h \
Expand Down
35 changes: 0 additions & 35 deletions include/os/freebsd/spl/sys/console.h

This file was deleted.

1 change: 0 additions & 1 deletion include/os/linux/spl/sys/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ KERNEL_H = \
callo.h \
cmn_err.h \
condvar.h \
console.h \
cred.h \
ctype.h \
debug.h \
Expand Down
30 changes: 0 additions & 30 deletions include/os/linux/spl/sys/console.h

This file was deleted.

1 change: 0 additions & 1 deletion include/sys/fm/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ typedef struct zfs_zevent {

extern void fm_init(void);
extern void fm_fini(void);
extern void fm_nvprint(nvlist_t *);
extern void zfs_zevent_post_cb(nvlist_t *nvl, nvlist_t *detector);
extern int zfs_zevent_post(nvlist_t *, nvlist_t *, zevent_cb_t *);
extern void zfs_zevent_drain_all(int *);
Expand Down
22 changes: 0 additions & 22 deletions man/man5/zfs-module-parameters.5
Original file line number Diff line number Diff line change
Expand Up @@ -3847,28 +3847,6 @@ set.
.sp
.RE

.sp
.ne 2
.na
\fBzfs_zevent_cols\fR (int)
.ad
.RS 12n
When zevents are logged to the console use this as the word wrap width.
.sp
Default value: \fB80\fR.
.RE

.sp
.ne 2
.na
\fBzfs_zevent_console\fR (int)
.ad
.RS 12n
Log events to the console
.sp
Use \fB1\fR for yes and \fB0\fR for no (default).
.RE

.sp
.ne 2
.na
Expand Down
Loading

0 comments on commit 1cb517a

Please sign in to comment.