Add type to feltlistmap #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandraLekve
commented
Oct 14, 2024
| @@ -117,6 +109,9 @@ object SøknadTreeWalker { | |||
| @Suppress("UNCHECKED_CAST") | |||
| return listOf(mapDokumentasjon(entitet as Søknadsfelt<Dokumentasjon>)) | |||
| } | |||
| if (entitet.label == "Barna dine"){ | |||
There was a problem hiding this comment.
Her burde det heller kanksje vært en litt bedre sjekk?
There was a problem hiding this comment.
Prøvde på entitet.verdi is Barn && entitet::class.isInstance(Barn) men det funket ikke
There was a problem hiding this comment.
tenkte mer på at vår variabel kan være på entitet:
if (entitet.visningsvariant === FeltType.TABLE) {
return listOf(feltlisteMap(entitet.label, list, FeltType.TABLE))
}
fredrikmork
reviewed
Oct 14, 2024
src/main/kotlin/no/nav/familie/ef/mottak/service/SøknadTreeWalker.kt
Outdated
Show resolved
Hide resolved
|
Jeg ser for meg at vi en god stund kommer til å leve med både ny og gammel løsning for generering parallelt i prod. Da er det viktig med bakoverkompatibilitet. Før dere merger denne PRen til main kunne dere:
Jeg skal komme med tips til generering av nye tester etter PO-samlingen, still gjerne spørsmål dersom noe er uklart 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beskrivelse:
Vi ønsker å ha en måte å skille hvordan enkelte deler av pdf-kvitteringen skal se ut og at det skal sende med informasjon fra søknaden.
Løsning:
Lagt til en type i feltlisteMap