Updated mail-validation, added new features #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored mail-validation Added new features, with new lookup-properties: - Kommunenavn (Norwegian municipality name) - Kommunenummer (Norwegian Municipalioty code) - Postnummer kategori (Norwegian postal area category) Updated postal data valid from 01.10.2020
eivinhb
reviewed
Feb 10, 2021
|
|
||
| Map<Postnummer, PostInfo> postInfo = new HashMap<>(); | ||
|
|
||
| InputStreamReader isr = new InputStreamReader(is, StandardCharsets.UTF_8); |
There was a problem hiding this comment.
Siden du allerede plukker i dette, om du hadde giddet å legge dette inn i en try with resource? Mye av dette er vel helt fra java 5/6..
There was a problem hiding this comment.
Jepp, skal få lagt inn det 👍
|
Sånn, da har jeg lagt inn try-with-resource 🤠 |
|
Veldig kult! Jeg antar at du ønsker å ha ut en release? Jeg kan fikse det ganske raskt. Det tar noen timer før det er i maven central. |
|
Så gøy! Ingen hast for min del, så om du vil ha med noe annet før ny release er det bare å vente på det 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored mail-validation
Added new features, with new lookup-properties:
Updated postal data valid from 01.10.2020