Skip to content

Commit

Permalink
add missing issue to change log
Browse files Browse the repository at this point in the history
  • Loading branch information
belav committed Dec 6, 2024
1 parent 384f7a1 commit 75249e5
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# 0.30.2
## What's Changed
### CSharpier.MsBuild now uses DOTNET_HOST_PATH instead of just dotnet [#1380](https://github.com/belav/csharpier/pull/1387)

This comment has been minimized.

Copy link
@PetSerAl

PetSerAl Dec 7, 2024

Contributor

It seems it should be [#1387] here, and on releases page.

This comment has been minimized.

Copy link
@belav

belav Dec 7, 2024

Author Owner

ah yeah, good catch!

This comment has been minimized.

Copy link
@belav

belav Dec 7, 2024

Author Owner

the header for each change is generated by some powershell, so either it has a bug that I haven't noticed before or I changed it and don't remember doing it.

This comment has been minimized.

Copy link
@belav

belav Dec 7, 2024

Author Owner

ah nevermind, this is the last release not the one I did today. Yeah I added this by hand.

Use current dotnet binary from DOTNET_HOST_PATH instead of just dotnet.
- Global (in PATH) may not exist (when used Binaries, but not Installers).
- Global can have different runtime version.
- Consistent with outer tools (csc for example).
https://github.com/dotnet/roslyn/blob/324fd25331c969cd742ba68eee09ffd4b6fd29e3/src/Compilers/Shared/RuntimeHostInfo.cs#L61-L64
- It is documented to be used for that purpose.
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-environment-variables#dotnet_host_path

### Collection expression inside a dictionary adds unexpected new line [#1390](https://github.com/belav/csharpier/issues/1390)
```c#
// input & expected output
Expand Down

0 comments on commit 75249e5

Please sign in to comment.