Skip to content

Commit

Permalink
Check for before destorying CSharpierProcessPipeMultipleFiles.java (#682
Browse files Browse the repository at this point in the history
)

* Check for before destorying CSharpierProcessPipeMultipleFiles.java

* Releasing 1.2.7 to fix NRE

Co-authored-by: Bela VanderVoort <twobitbela@gmail.com>
  • Loading branch information
jojoman2 and belav authored Jul 3, 2022
1 parent 6bfddb7 commit d9b3b90
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 2 deletions.
3 changes: 3 additions & 0 deletions Src/CSharpier.Rider/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

# csharpier-rider Changelog

## [1.2.7]
- Fix Null Reference Exception from CSharpierProcessPipeMultipleFiles if it fails to start process

## [1.2.6]
- Remove plugin until property so plugin doesn't need to be updated for each new rider version

Expand Down
11 changes: 11 additions & 0 deletions Src/CSharpier.Rider/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,14 @@ Please report any [issues](https://github.com/belav/csharpier/issues)
---
Plugin based on the [IntelliJ Platform Plugin Template][template].

## Troubleshooting

### Viewing CSharpier Logs
- Use the action "Show Log in Explorer"
- Look for entries for "CSharpierLogger"

### Enable Debug Logging for CSharpier
- Use the action "Debug Log Settings"
- Add entry for "#com.intellij.csharpier.CSharpierLogger"
- Restart Rider

2 changes: 1 addition & 1 deletion Src/CSharpier.Rider/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
pluginGroup = com.intellij.csharpier
pluginName = csharpier
# SemVer format -> https://semver.org
pluginVersion = 1.2.6
pluginVersion = 1.2.7

# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
# for insight into build numbers and IntelliJ Platform versions.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ public String formatFile(String content, String filePath) {

@Override
public void dispose() {
this.process.destroy();
if (this.process != null) {
this.process.destroy();
}
}
}

0 comments on commit d9b3b90

Please sign in to comment.