Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment removed after reformatting #1300

Closed
Nasicus opened this issue Jul 9, 2024 · 1 comment · Fixed by #1301
Closed

Comment removed after reformatting #1300

Nasicus opened this issue Jul 9, 2024 · 1 comment · Fixed by #1301
Milestone

Comments

@Nasicus
Copy link

Nasicus commented Jul 9, 2024

Thanks for the great work you're doing with csharpier!
A small issue I just noticed:

Input:

public static class ExclusiveBrands
{
    public static readonly HashSet<int> Ids =
    [
        593, // Fish Brand
    ];
}

Output:

public static class ExclusiveBrands
{
    public static readonly HashSet<int> Ids = [593];
}

Expected behavior:

=> do not remove comment (probably leave as is?)

@belav
Copy link
Owner

belav commented Jul 10, 2024

Thanks for the kind words! This looks like an edge case of the recent logic around auto adding trailing comments, it'll be resolved in the next release.

@belav belav added this to the 0.29.0 milestone Jul 10, 2024
pisolofin pushed a commit to pisolofin/csharpier-editorconfig that referenced this issue Aug 22, 2024
…#1301)

closes belav#1300

---------

Co-authored-by: Lasath Fernando <devel@lasath.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants