Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into the failures in the "format repositories" action #1312

Closed
belav opened this issue Jul 27, 2024 · 0 comments · Fixed by #1317
Closed

Look into the failures in the "format repositories" action #1312

belav opened this issue Jul 27, 2024 · 0 comments · Fixed by #1317
Milestone
0.29.0

Comments

@belav
Copy link
Owner

belav commented Jul 27, 2024

https://github.com/belav/csharpier/actions/runs/10125946977/job/28002012957

It seems to be just that it doesn't understand the trailing commas on enums.

Also get the site working well on mobile, it probably broke with the docusaurus update.
@belav belav added this to the 0.29.0 milestone Jul 27, 2024
belav added a commit that referenced this issue Aug 16, 2024
@belav
When an #if directive has a comma added with it, then the syntax node…
c8bea3a 
… validation fails because it is not comparing the syntax nodes.

closes #1312
@belav belav mentioned this issue Aug 16, 2024
Merged
@belav belav closed this as completed in cb64721 Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.29.0
Development

Successfully merging a pull request may close this issue.

When an #if directive has a comma added with it, then the syntax node… belav/csharpier
1 participant
@belav