Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET 9 #1378

Closed
sin-ack opened this issue Nov 13, 2024 · 7 comments
Closed

Support .NET 9 #1378

sin-ack opened this issue Nov 13, 2024 · 7 comments

Comments

@sin-ack
Copy link

sin-ack commented Nov 13, 2024

.NET 9 just got released, would be cool if we could use Csharpier with it.

Environments:

  • CSharpier Version: 0.29.2
  • Running CSharpier via: dotnet cli
  • Operating System: Gentoo Linux amd64
  • .csharpierrc Settings: (empty)
  • .editorconfig Settings: (empty)

Steps to reproduce:

  1. Install .NET SDK 9.0.100
  2. dotnet tool install csharpier
  3. dotnet dotnet-csharpier

Expected behavior:

Nicely formatted code.

Actual behavior:

» dotnet dotnet-csharpier
You must install or update .NET to run this application.

App: /home/*snip*/.nuget/packages/csharpier/0.29.2/tools/net8.0/any/dotnet-csharpier.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0' (x64)
.NET location: /home/*snip*/tmp/dotnet-9.0/

The following frameworks were found:
  9.0.0 at [/home/*snip*/tmp/dotnet-9.0/shared/Microsoft.NETCore.App]

Learn more:
https://aka.ms/dotnet/app-launch-failed

To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=x64&rid=linux-x64&os=gentoo.2.15
@sin-ack
Copy link
Author

sin-ack commented Nov 13, 2024

As a workaround, dotnet tool install --allow-roll-forward csharpier lets Csharpier run for the time being, but I don't know if that causes issues.

@belav
Copy link
Owner

belav commented Nov 13, 2024

I've added support in #1318 which will be out with the next release. Just have a couple of things to finish up for that release. It also sounds like I may be able to change csharpier to roll forward automatically to avoid this for next time. I'll leave this open so I can look into that.

@belav belav added this to the 1.0.0 milestone Nov 13, 2024
@PetSerAl
Copy link
Contributor

Just adding <RollForward>Major</RollForward> in the project file should do the trick.

@JesperLundberg
Copy link
Contributor

Just adding my request for getting support for dotnet 9 release... released. :)

Also, big thanks for your work. I don't understand how I could live without a formatter for so long before I started using CSharpier.

@belav belav removed this from the 1.0.0 milestone Nov 17, 2024
shortcuts added a commit to algolia/api-clients-automation that referenced this issue Nov 18, 2024
@liri2006
Copy link

liri2006 commented Dec 4, 2024

Hi @belav, Any ETA when this would be released?

@belav
Copy link
Owner

belav commented Dec 4, 2024

@liri2006 support for net9 went out with 0.30.0, the work was done on #1318. I forgot to close out this issue.

@belav belav closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
@liri2006
Copy link

liri2006 commented Dec 5, 2024

@belav, oops, did not check the actual csharpier version, only the Rider plugin one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants