-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode 1.9.0 - Diagnostics always showing even when ext is not the formatter #1403
Comments
I've added an option to disable this for now. I think It makes sense to disable these diagnostics when csharpier is not the formatter. @badsyntax do you happen to know how to find the current formatter? I was thinking it would be quick to make this change but wasn't able to track down how to get that information in an extension. |
This is awesome! I think keeping the option in the long run might even be a good thing. For the little I saw the result, is really was in my way. |
@belav I'll take a look later this week |
Nice solution. I agree with @scabana that the option should be left. |
Environments
will NOT be the same as the extension version
Log Output
Steps to reproduce
Expected behavior
When CSharpier is not the selected formatter, no diagnostics should show up.
When adopting CSharpier, not all repositories will have CSharpier setup.
Actual behavior
CSharpier diagnostics shows up (seems related to this commit
The text was updated successfully, but these errors were encountered: