SwitchStatement with When breaks even with body of switch

[belav]

This is a side effect of #384 I found while testing the changes on https://github.com/belav/aspnetcore

With a regular switch statement, when the when breaks, it ends up inline with the body of the case statement

        switch (expression.Body)
        {
            case var body when body == expression.Parameters[0]:
                return CompileFromIdentityFunc(expression);
            case MemberExpression memberExpression
                when memberExpression.Expression is ConstantExpression constantExpression:
                return CompileCapturedConstant(memberExpression, constantExpression);
            default:
                return null;
        }

Here are a bunch of ideas I came up with for how to deal with it.

Use align 2 on the when

        switch (expression.Body)
        {
            case var body when body == expression.Parameters[0]:
                return CompileFromIdentityFunc(expression);
            case MemberExpression memberExpression
              when memberExpression.Expression is ConstantExpression constantExpression:
                return CompileCapturedConstant(memberExpression, constantExpression);
            default:
                return null;
        }

Use align 2 on the body of the case

        switch (expression.Body)
        {
            case var body when body == expression.Parameters[0]:
              return CompileFromIdentityFunc(expression);
            case MemberExpression memberExpression
                when memberExpression.Expression is ConstantExpression constantExpression:
              return CompileCapturedConstant(memberExpression, constantExpression);
            default:
              return null;
        }

Line up the when with the case

        switch (expression.Body)
        {
            case var body when body == expression.Parameters[0]:
                return CompileFromIdentityFunc(expression);
            case MemberExpression memberExpression
            when memberExpression.Expression is ConstantExpression constantExpression:
                return CompileCapturedConstant(memberExpression, constantExpression);
            default:
                return null;
        }

Indent and align 2 the when

        switch (expression.Body)
        {
            case var body when body == expression.Parameters[0]:
                return CompileFromIdentityFunc(expression);
            case MemberExpression memberExpression
                  when memberExpression.Expression is ConstantExpression constantExpression:
                return CompileCapturedConstant(memberExpression, constantExpression);
            default:
                return null;
        }

I think I lean towards Line up, or Indent + Align2

@pmccloghrylaing and @shocklateboy92, what do you think?

[shocklateboy92]

What would it look like if you double indent the when?

[belav]

Looks similar to Ident + Align2, I think I might like it a little better

        switch (expression.Body)
        {
            case var body when body == expression.Parameters[0]:
                return CompileFromIdentityFunc(expression);
            case MemberExpression memberExpression
                    when memberExpression.Expression is ConstantExpression constantExpression:
                return CompileCapturedConstant(memberExpression, constantExpression);
            default:
                return null;
        }