Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSharpier.MSBuild may have mismatched version with CLI #490

Closed
belav opened this issue Nov 23, 2021 · 0 comments · Fixed by #512
Closed

CSharpier.MSBuild may have mismatched version with CLI #490

belav opened this issue Nov 23, 2021 · 0 comments · Fixed by #512
Milestone
0.13.0

Comments

@belav
Copy link
Owner

belav commented Nov 23, 2021 •
edited
Loading

  • Have csharpier installed globally, with version 0.11.2
  • In a project, have CSharpier.MSBuild installed with version 0.10.0
  • From the command line, run dotnet csharpier .

The code will be formatted with 0.11.2. The build will complain that your code is not formatted.

One possible solution is the CLI looking for CSharpier.MSBuild in any of the csprojs, and erroring out if there is a version mismatch.
@belav belav mentioned this issue Dec 6, 2021
Closed
belav added a commit that referenced this issue Dec 6, 2021
@belav
Detect mismatch between cli and msbuild versions
dd90344 
closes #490
belav added a commit that referenced this issue Dec 6, 2021
@belav
Detect mismatch between cli and msbuild versions
9ddd2ca 
closes #490
@belav belav mentioned this issue Dec 6, 2021
Merged
@belav belav added this to the 0.13.0 milestone Dec 6, 2021
belav added a commit that referenced this issue Dec 6, 2021
@belav
Detect mismatch between cli and msbuild versions
40944fc 
closes #490
@belav belav closed this as completed in #512 Dec 6, 2021
belav added a commit that referenced this issue Dec 6, 2021
@belav
Detect mismatch between cli and msbuild versions (#512)
e04d8f5 
closes #490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Detect mismatch between cli and msbuild versions belav/csharpier
1 participant
@belav