MSBuild Task target too late?

[OneCyrus]

I really like the MSBuild task through the nuget package. This makes it very easy to have csharpier enabled in a project. It works almost perfectly except we are facing an issue when debugging and csharpier changes the code. The breakpoints fail as we have code changes after "building". Maybe csharpier can be run earlier than TargetBefore="Build" to solve this? any idea?

[belav]

It was setup to run before Build, but looking at a log of the build output, I could see that is was running after everything else and I reproduced the problem you were seeing with breakpoints not being hit properly.
Switching it to run before CoreCompile appears to have resolved the issue.

Thanks for reporting the problem!

[OneCyrus]

we still run into this bug from time to time. not sure if it has anything to do with multiple projects. I'm trying to find a good way to reproduce it. not sure if anything has changed as I think it worked perfectly after the 0.17.0 release.

@belav any idea about a regression here?

[belav]

@OneCyrus there haven't been any changes to the MSBuild side of things since 0.17.0. The new caching in CSharpier did cause some issues, but those were exceptions that would have looked quite a bit different than this problem. If there is an issue with the caching causing CSharpier to not format a file because it believes it is already formatted - then I don't believe that would result in the source code looking different from what was used to compile.

The build output should give you an indication of what CSharpier is doing, which may help.

[OneCyrus]

just did a very simple reproduction.

1. Clone a hello world repo (https://github.com/NamAdonis/HelloWorld.git)
2. Add CSharpier.MsBuild to the project
3. Wrap line for Console.WriteLine
4. Set Breakpoint to line below (Console.ReadLine)
5. Execute (F5) and see that breakpoint is not active anymore

Screenrecording: