fix: bugs from #1066 #1078
Merged
fix: bugs from #1066 #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group id used in ArgumentListLikeSyntax was not unique and the nested lambda overrode the state of the parent lambda
shocklateboy92
previously approved these changes
Dec 18, 2023
There was a problem hiding this comment.
LGTM.
Do you want to merge this as is, and fix the second bug mentioned in #1077 in a separate PR?
Or should I wait for you to push the fix for the second one also into this branch?
| @@ -10,14 +10,15 @@ FormattingContext context | |||
| ) | |||
| { | |||
| var docs = new List<Doc> { Token.Print(openParenToken, context) }; | |||
| var lambdaId = Guid.NewGuid(); | |||
|
|
|||
| switch (arguments) | |||
There was a problem hiding this comment.
I forgot to mention this in your original PR, but this all branches of this switch statement just add something to the list.
Wouldn't it look better if you used the switch expression instead?
There was a problem hiding this comment.
The expression looks almost the same for me
|
I will fix the second bug in other PR |
Closes #1077
|
Well, I've fixed the last bug before PR is merged, so I've decided to add the changes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the first and third bugs described in #1077