-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent line endings in tests #1288
Fix inconsistent line endings in tests #1288
Conversation
e073fd4
to
275fa00
Compare
@jamesfoster what exactly is this for? Could you clarify a little what you mean by "inconsistent line endings"? |
I explain in this comment After a clean checkout of the repo on windows, several tests fail because of line ending mismatches. |
Also notice these checks are failing. I turned on csharpier formatting on save but clearly missed a file somewhere. I'll reformat and update the branch with main later today |
Apologies for the delay. I had a hectic weekend. Will get to this today. |
1c425f1
to
56056b6
Compare
56056b6
to
e69679c
Compare
Rebased onto |
@shocklateboy92 @belav There is still one test that fails for me locally. csharpier/Src/CSharpier.Cli.Tests/CliTests.cs Lines 118 to 131 in bc331cd
The exit code is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution.
@belav #1288 (comment) |
Hey @jamesfoster, sorry I rudely completed the PR to get it off my queue 😛 As for your issue, you can run the test locally with a debugger breakpoint and see if it reaches this validator:
|
Thanks @shocklateboy92 I'll look into it |
I have the same issue. csharpier/Src/CSharpier.Cli.Tests/CliTests.cs Line 561 in 75a582b
Can @jamesfoster halp me? Thanks. |
No description provided.