Modify VSCode extension to use dotnet tool list + only warn to instal… #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l csharpier once + auto exclude some directories from warning. #1267
pisolofin
pushed a commit
to pisolofin/csharpier-editorconfig
that referenced
this pull request
Aug 22, 2024
belav#1323) This modifies the VSCode extension in the following ways - Instead of looking for dotnet-tools.json files in the current directory and parent directories the extension runs `dotnet tool list` and parses the outpud looking for the csharpier version. - Instead of running `dotnet csharpier --version` to look for the global version it repeats the above step with `dotnet tool list -g` - The "You need to install csharpier" window was popping up every time you opened a file if it couldn't find an install. The other extensions were limited to showing the warning a single time. VSCode now only shows it a single time. - Files under `/DecompilationMetadataAsSourceFileProvider/` will never have the warning show. This is where the c# dev kit decompiles code. belav#1267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the VSCode extension in the following ways
dotnet tool listand parses the outpud looking for the csharpier version.dotnet csharpier --versionto look for the global version it repeats the above step withdotnet tool list -g/DecompilationMetadataAsSourceFileProvider/will never have the warning show. This is where the c# dev kit decompiles code.#1267