Update diffengine #1350
Open
Update diffengine #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belav
requested changes
Sep 23, 2024
Comment on lines
+22
to
+34
| static string LeftArguments(string temp, string target) | ||
| { | ||
| var tempTitle = Path.GetFileName(temp); | ||
| var targetTitle = Path.GetFileName(target); | ||
| return $"/u /wr /e \"{target}\" \"{temp}\" /dl \"{targetTitle}\" /dr \"{tempTitle}\" /cfg Backup/EnableFile=0"; | ||
| } | ||
|
|
||
| static string RightArguments(string temp, string target) | ||
| { | ||
| var tempTitle = Path.GetFileName(temp); | ||
| var targetTitle = Path.GetFileName(target); | ||
| return $"/u /wl /e \"{temp}\" \"{target}\" /dl \"{tempTitle}\" /dr \"{targetTitle}\" /cfg Backup/EnableFile=0"; | ||
| } |
There was a problem hiding this comment.
The files show up in winmerge properly, but these changes result in the TestCase.actual.test file being editable, when it should be TestCase.test that is editable.
Or in other words "Copy from Left" is an option, but should not be, and "Copy to Left" is unavailable but should be.
There was a problem hiding this comment.
Ah... Probably temp and target need to change the position..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.