Fixing some edge cases for initializers #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shocklateboy92
approved these changes
Jul 9, 2021
respel
reviewed
Jul 10, 2021
| InvocationExpressionSyntax | ||
| or ParenthesizedLambdaExpressionSyntax | ||
| or ObjectCreationExpressionSyntax | ||
| or ElementAccessExpressionSyntax | ||
| or ArrayCreationExpressionSyntax | ||
| or InitializerExpressionSyntax |
There was a problem hiding this comment.
This might be redundant since you're including it above anyway.
respel
reviewed
Jul 10, 2021
| @@ -21,10 +21,20 @@ string groupId | |||
| return Print(node, groupId); | |||
| } | |||
|
|
|||
| private static Doc Print(InitializerExpressionSyntax node, string? groupId) | |||
| public static Doc PrintWithLine(InitializerExpressionSyntax node) | |||
There was a problem hiding this comment.
suggestion: I think stuff like PrintWithLine and PrintWithConditionalSpace might be better placed inlined at the call site rather than have special functions for one-off use cases.
There was a problem hiding this comment.
I was able to move the logic for PrintWithLine into InitializerExpression itself.
And because PrintWithConditionalSpace ended up not using the Doc.Group, the logic for that could be inlined in ObjectCreationExpression.
Much nicer this way!
Don't worry, I was just on a long vacation. I'll fill up your inbox with new PRs soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #335
closes #336