Make sure empty block doesn't break on method declaration #360
Conversation
Src/CSharpier/SyntaxPrinter/Token.cs
Outdated
| { | ||
| return syntaxToken.LeadingTrivia.Any( | ||
| o => | ||
| o.Kind() != SyntaxKind.WhitespaceTrivia |
There was a problem hiding this comment.
Minor point, but can you use pattern watching with enums here?
o.Kind() is not WhitespaceTrivia or EndOfLineTrivia
There was a problem hiding this comment.
yes, for some reason I have it in my head that it doesn't work with Kind()
| @@ -21,6 +21,19 @@ public static Doc PrintWithConditionalSpace(BlockSyntax node, string groupId) | |||
|
|
|||
| private static Doc Print(BlockSyntax node, string? groupId) | |||
| { | |||
| if ( | |||
| node.Statements.Count == 0 | |||
There was a problem hiding this comment.
Mabybe I'm getting carried away with pattern matching, but would something like this be valid?
node is { Statements: { Count: 0 }, Parent: MethodDeclarationSyntax {} }
There was a problem hiding this comment.
It does work but it seems harder to understand, but maybe that's because of how CSharpier formats it.
if (
node is { Statements: { Count: 0 }, Parent: MethodDeclarationSyntax }
&& !Token.HasComments(node.CloseBraceToken)
) {If it was formatted this way it could be easier to understand
if (
node is
{
Statements: { Count: 0 },
Parent: MethodDeclarationSyntax
}
&& !Token.HasComments(node.CloseBraceToken)
) {It could also be that I'm still somewhat new to reading this type of pattern matching.
|
I'm merging this because the generic class stuff has a similar edge case |
closes #133