Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of improvements to the VSCode extension #543

Merged
merged 8 commits into from
Jan 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .github/workflows/validate_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,3 @@ jobs:
dotnet-version: '6.0.x'
- run: |
dotnet build Src/CSharpier.MsBuild/CSharpier.MsBuild.csproj
# run_vscode_tests:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh... is this intentional? Running tests on PR seems useful.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were failing randomly 50% of the time and it doesn't seem worth the effort to try to fix them. It is pretty fast to test them manually when the extension changes, which shouldn't be very often.

# runs-on: ${{ matrix.os }}
# strategy:
# matrix:
# os: [ ubuntu-latest ] #, windows-latest, macos-latest ]
# name: Test VSCode on ${{ matrix.os }}
# steps:
# - uses: actions/checkout@v2
# - uses: actions/setup-node@v2
# with:
# node-version: "14"
# - run: /usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & echo "Started xvfb"
# shell: bash
# if: ${{ success() && matrix.os == 'ubuntu-latest' }}
# - uses: actions/setup-dotnet@v1
# with:
# dotnet-version: '6.0.x'
# - run: |
# dotnet build CSharpier.sln -c release
# cd Src/CSharpier.VSCode
# npm ci
# npm test
# env:
# DISPLAY: ":99.0"
25 changes: 25 additions & 0 deletions Src/CSharpier.VSCode/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
## [1.1.0]

- Support local version of csharpier
- Support multiple versions of csharpier in the same workspace
- Auto close csharpier process so that it can be updated while vscode is running

## [1.0.4]

- Update readme

## [1.0.3]

- New logo

## [1.0.2]

- Fix bug with long files sometimes losing content

## [1.0.1]

- Fix bug with ignored files

## [1.0.0]

- Initial release
9 changes: 9 additions & 0 deletions Src/CSharpier.VSCode/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
npm run start
then start extension from vscode
ctrl r to reload window (Developer: Reload Window)

https://code.visualstudio.com/api/working-with-extensions/publishing-extension

vsce package
vsce publish

https://marketplace.visualstudio.com/manage/publishers/csharpier
2 changes: 0 additions & 2 deletions Src/CSharpier.VSCode/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,4 @@ You can turn on format-on-save on a per-language basis by scoping the setting:

## Limitations

This extension currently only works with a globally installed version of csharpier. See [this issue](https://github.com/belav/csharpier/issues/493) for details.

Format Selection is not supported.
Binary file removed Src/CSharpier.VSCode/icon.png
Binary file not shown.
Binary file added Src/CSharpier.VSCode/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading