Updates to VS extensions #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have to add the installer actions and also run through all the tests cases. But the bulk of the code changes are here. |
shocklateboy92
approved these changes
Feb 6, 2022
| "dotnet", | ||
| csharpierPath + " --pipe-multiple-files" | ||
| ) | ||
| var processStartInfo = new ProcessStartInfo(csharpierPath, " --pipe-multiple-files") |
There was a problem hiding this comment.
I guess this is fine, since VS doesn't run on platforms other than windows.
| private bool warnedForOldVersion; | ||
|
|
||
| private readonly Dictionary<string, bool> warmingByDirectory = new Dictionary< | ||
| string, |
There was a problem hiding this comment.
This is not super relevant to this PR, but I really think we should break on = before any of the other things.
There was a problem hiding this comment.
agreed! this was the code I saw that spurred #578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the VS extensions up to date with Rider and VSCode.
Use DOTNET_NOLOGO - fixes #533 and #549
Use a custom tools path to allow csharpier to be updated/installed while running - fixes #563 and #531
Use the solution version of csharpier - fixes #493