Consistently indent by 4 spaces (or by tabs) #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belav
changed the title
belav
force-pushed
the
ditch-align2
branch
2 times, most recently
from
ab8f7dd
to
c5c73c3
Compare
belav
changed the title
shocklateboy92
approved these changes
May 9, 2022
| return Doc.Group( | ||
| Doc.Indent(groupId != null ? Doc.IfBreak(" ", prefix, groupId) : prefix), | ||
| groupId != null | ||
| ? Doc.IfBreak(Doc.Align(2, body), Doc.Indent(body), groupId) |
There was a problem hiding this comment.
Heh, funny we never extracted the 2 to a constant. I was kind of hoping this change (on the code side) would be a simple HalfIndent = DefaultIndent 😏
| || node.Parent is ConditionalExpressionSyntax | ||
| && node.Parent.Parent is not ArgumentSyntax; | ||
| || ( | ||
| node.Parent is ConditionalExpressionSyntax conditionalExpressionSyntax |
There was a problem hiding this comment.
I think you could have done some fancy pattern matching shenanigans like:
node.Parent is ConditionalExpressionSyntax
{
WhenTrue: not node,
WhenFalse: not node
}
Though, I don't know if it will allow node as the target or if it needs to be a literal value.
There was a problem hiding this comment.
I just tried it out, it does require a constant value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #617