fix: ignore file detection when directory contains period #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using CSharpier in a project whose directory name contained a period, e.g.,
/home/jsanchezio/Documents/Repos/My.Project/
, and despite having a.csharpierignore
file, it would still report files excluded by the ignore as unformatted. I was running the command asdotnet csharpier --check .
After some investigation, it turns outfileSystem.Path.GetExtension(directoryOrFile)
would return the path after the period, e.g.,.Project
. This change alters the command to instead check if thedirectoryOrFile
is a directory that exists and reacts accordingly.After I discovered the issue, I renamed my project's folder name and all worked well. However, in CI environments there is no guarantee that a
.
won't be in the path, so I figured it was best to handle it within CSharpier.