Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with an edge case for conditional access #640

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Dealing with an edge case for conditional access #640

merged 2 commits into from
Apr 7, 2022

Conversation

belav
Copy link
Owner

@belav belav commented Apr 4, 2022

closes #603

shocklateboy92
shocklateboy92 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure I like breaking after the property access.
But it makes no sense for conditional access to be different than regular access, so...

@shocklateboy92 shocklateboy92 merged commit e94e002 into master Apr 7, 2022
@shocklateboy92 shocklateboy92 deleted the conditional-edge-case branch April 7, 2022 00:34
@belav
Copy link
Owner Author

belav commented Apr 7, 2022

TBH I'm not sure I like breaking after the property access.

I have similar thoughts, it was copied from prettier and I'm not in love with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shocklateboy92 shocklateboy92 shocklateboy92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional access edge cases
2 participants
@belav @shocklateboy92