-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use relative file path in CommandLineFormatter #680
Conversation
This changes the format of the file name to add a leading "." so that the path is a relative path instead of an absolute path. Modern terminal programs allow control-clicking on paths to jump to a file, so if this is a relative path, we can jump to the file. If it is printed as an absolute path, this doesn't work.
I think this is a great idea but I did find a couple issues. I think I added a unit test to recreate the first, but I am having trouble running the unit tests right now. The source generators are causing me some pain after I started looking at supporting c# 11. I at least managed to build things so that I could test the cli.
|
I may have my terminology confused. If csharpier is supplied a relative path, like And it looks like if you supply a path as |
Thanks for fixing this up. I didn't have time to get back to it yet. |
You're welcome! |
This changes the format of the file name to add a leading "." so that the path is a relative path instead of an absolute path.
Modern terminal programs allow control-clicking on paths to jump to a file, so if this is a relative path, we can jump to the file. If it is printed as an absolute path, this doesn't work.