Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put constructor initializer on new line #782

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Put constructor initializer on new line #782

merged 1 commit into from
Jan 9, 2023

Conversation

belav
Copy link
Owner

@belav belav commented Jan 7, 2023 •
edited
Loading

closes #526

@belav belav force-pushed the new-line-constructor-initializers branch from 71b94be to 4a47bfe Compare January 7, 2023 17:09
shocklateboy92
shocklateboy92 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you link the wrong bug? I don't see how that's related to this change at all. 🤷

@belav
Copy link
Owner Author

belav commented Jan 9, 2023

Did you link the wrong bug? I don't see how that's related to this change at all. 🤷

Ah yeah, I updated the commit but missed updating the PR.

@belav belav merged commit ccff28f into master Jan 9, 2023
@belav belav deleted the new-line-constructor-initializers branch January 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shocklateboy92 shocklateboy92 shocklateboy92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider always putting constructor initializers on their own line
2 participants
@belav @shocklateboy92