Only read files that are UTF8 or UTF8 BOM #787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #768
Previously UTF.Unknown was used to try to determine file encodings. This was problematic because if a file was too small, it would end up with several possible encodings. The encoding it considered most likely was not always correct. As opposed to trying to read a file as each encoding type, CSharpier now only supports UTF8 files. This is consistent with the IDE plugins, which stream files to CSharpier as UTF8. If a file is UTF8-BOM, it will retain the BOM.