Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update currency list in BalanceResponse #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RoanBrand
Copy link

IMO opinion all amounts and prices must be kept as strings. I have run into many problems with using float64 or even big.Float when working with money. This is the same reason the API uses strings.

I also added currencies that were in the API docs response example. I realize there is even more currencies on the exchange now that they haven't added to the docs. This needs to be changed to a dynamic response map[string]string or []string{symbol, balance} so that all currency changes will just work, and not to mention easier for users to handle.

I need this, so will be changing along as I need on my forked version. I can make additional future PRs if you want.

@beldur
Copy link
Owner

beldur commented Oct 28, 2021

Thanks for your input Roan!
I get your point and think the idea is not far fetched. Would it be possible for you to write some down some example's where this is problematic? If we do this breaking change, we should document the reasoning behind it here in this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants