Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-value query param should be noun if singular #160

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

pvdbosch
Copy link
Contributor

@pvdbosch pvdbosch commented Nov 30, 2023

  • Multi-value query param should be singular if noun
  • don't set param properties that are already default in example OpenAPI

- don't set param properties that are already default in example OpenAPI
@pvdbosch
Copy link
Contributor Author

pvdbosch commented Nov 30, 2023

to check with WG if introducing new guideline (Multi-value query param should be singular if noun) is OK.
Seems to be consistent with examples already present

Example: ?color=blue&color=red vs ?colors=blue&colors=red

Pro: makes more sense when reading URL
Con: singular makes less sense in generated code, e.g. List<String> color

@pvdbosch
Copy link
Contributor Author

Reviewed by WG, OK to merge

@pvdbosch pvdbosch merged commit 79b5d9e into master Jan 30, 2024
1 check passed
@pvdbosch pvdbosch deleted the feature/multi-value-singular branch January 31, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant