added a check for Enable_OTel Enviromental variable #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check for a enviromental variable to explicitly enable OTEL, other wise set the application to output to stdout. in conjunction with ENABLE_OTEL you have to have the OTEL as a default feature, if you don't have Otel as feature need to add tracing-subscriber as one. this could probably be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a custom ENV Variable to enable OTEL called "ENABLE_OTEL". having this in ENV and having the feature set in the default with enable OTEL, other wise if ENABLE_OTEL is not present it will default to outputting to std-out.
has relevant logging to show this.
let me know of any improvements.
right now it is Opt-in, this could easily change to opt-out if needed, I think most people wouldn't want OTEL to be setup unless the explicitly wanted it so this way it can easily be used without needing to make sure to disable it