Closed
Conversation
Bonjour Fabrice, In this push request, I went through README.md and fixed things that I thought were grammar or plural issues. I threw in a link to the Wikipedia page for Golomb codes, thinking that might not hurt. I've not seen them before and thought others also might not have seen them. Keep or throw away whichever of the changes in there. Hope you have a great Christmas! Cheers, DC
Hi Fabrice, Pardon that I didn't get this into the orginal pull request. These are just a few grammatical things again. Keep or discard as you'd like. Merci, DC
One or two other changes.
Author
|
Hi Fabrice, |
Saevyn
suggested changes
Dec 24, 2025
Saevyn
left a comment
Saevyn
left a comment
There was a problem hiding this comment.
These are pretty good fixes! I was about to open a pull request to fix some errors I found, but it seems like you already found all of them, with the exception of this small one.
| Javascript constructs are forbidden. | ||
|
|
||
| Although MQuickJS shares many code with QuickJS, it internals are | ||
| Although MQuickJS shares much code with QuickJS, it internals are |
There was a problem hiding this comment.
Suggested change
| Although MQuickJS shares much code with QuickJS, it internals are | |
| Although MQuickJS shares much code with QuickJS, its internals are |
Saevyn
suggested changes
Dec 24, 2025
Saevyn
left a comment
Saevyn
left a comment
There was a problem hiding this comment.
I also noticed that JavaScript is spelled with a lowercase s throughout the document, so I tried to fix that as well. Now, I don't know if this is the best way to do this, or if I should have opened a new PR instead, so let me know if I'm doing anything wrong!
| @@ -4,16 +4,16 @@ | |||
| ## Introduction | |||
|
|
|||
| MicroQuickJS (aka. MQuickJS) is a Javascript engine targetted at | |||
There was a problem hiding this comment.
Suggested change
| MicroQuickJS (aka. MQuickJS) is a Javascript engine targetted at | |
| MicroQuickJS (aka. MQuickJS) is a JavaScript engine targetted at |
|
|
||
| MicroQuickJS (aka. MQuickJS) is a Javascript engine targetted at | ||
| embedded systems. It compiles and runs Javascript programs with as low | ||
| embedded systems. It compiles and runs Javascript programs using as little |
There was a problem hiding this comment.
Suggested change
| embedded systems. It compiles and runs Javascript programs using as little | |
| embedded systems. It compiles and runs JavaScript programs using as little |
| Thumb-2 code) including the C library. The speed is comparable to | ||
| QuickJS. | ||
|
|
||
| MQuickJS only supports a [subset](#javascript-subset-reference) of Javascript close to ES5. It |
There was a problem hiding this comment.
Suggested change
| MQuickJS only supports a [subset](#javascript-subset-reference) of JavaScript close to ES5. It |
|
|
||
| MQuickJS only supports a [subset](#javascript-subset-reference) of Javascript close to ES5. It | ||
| implements a **stricter mode** where some error prone or inefficient | ||
| Javascript constructs are forbidden. |
There was a problem hiding this comment.
Suggested change
| Javascript constructs are forbidden. | |
| JavaScript constructs are forbidden. |
|
|
||
| ## Stricter mode | ||
|
|
||
| MQuickJS only supports a subset of Javascript (mostly ES5). It is |
There was a problem hiding this comment.
Suggested change
| MQuickJS only supports a subset of JavaScript (mostly ES5). It is |
|
|
||
| - `for in` only iterates over the object own properties. It should be | ||
| used with this common pattern to have a consistent behavior with | ||
| standard Javascript: |
|
|
||
| As with QuickJS, no backward compatibility is garanteed at the | ||
| bytecode level. Moreover, the bytecode is not verified before being | ||
| executed. Only run Javascript bytecode from trusted sources. |
There was a problem hiding this comment.
Suggested change
| executed. Only run JavaScript bytecode from trusted sources. |
| memory. | ||
|
|
||
| Javascript objects requires at least 3 CPU words (hence 12 bytes on a | ||
| Javascript objects require at least 3 CPU words (hence 12 bytes on a |
There was a problem hiding this comment.
Suggested change
| Javascript objects require at least 3 CPU words (hence 12 bytes on a | |
| JavaScript objects require at least 3 CPU words (hence 12 bytes on a |
| Strings are internally stored in UTF-8 (instead of 8 or 16 bit arrays | ||
| in QuickJS). Surrogate pairs are not stored explicitly but still | ||
| in QuickJS). Surrogate pairs are not stored explicitly but are still | ||
| visible when iterating thru 16 bit code units in Javascript. Hence full |
There was a problem hiding this comment.
Suggested change
| visible when iterating thru 16 bit code units in Javascript. Hence full | |
| visible when iterating thru 16 bit code units in JavaScript. Hence full |
| in QuickJS). Surrogate pairs are not stored explicitly but still | ||
| in QuickJS). Surrogate pairs are not stored explicitly but are still | ||
| visible when iterating thru 16 bit code units in Javascript. Hence full | ||
| compatibility with Javascript and UTF-8 is maintained. |
There was a problem hiding this comment.
Suggested change
| compatibility with Javascript and UTF-8 is maintained. | |
| compatibility with JavaScript and UTF-8 is maintained. |
Owner
|
Thank you for the spelling fixes. I applied most of them and made other changes as well. |
|
I don't mean to be a nuisance, but it appears that the missing I also found another instance of “Javascript” in the repository's description. Just thought you'd like to know! |
This was referenced Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bonjour Fabrice,
In this pull request, I went through README.md and fixed things that I thought were grammar or plural issues.
I threw in a link to the Wikipedia page for Golomb codes, thinking that might not hurt. I've not seen them before and thought others also might not have seen them.
Keep or throw away whichever of the changes as you like!
Hope you have a great Christmas!
Merci,
DC