Closed
Conversation
Owner
|
Thank you for the links. Your unit test does not add significant tests so I don't think it is worth adding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a low-level unit test check for basic functional compatibility with the js tooling i'm toying around with, run the tests with
Excellent stuff @bellard, I'm always impressed with your work. this is the foundation that i assume for my silly stack.
I have a quickjs repl in browser at:
https://plan98.org/app/js-repl
a quick js repl can be open in browser by running the
jscommand in the shellhttps://plan98.org/app/ur-shell
the unit test brought in here is a minimal fork of the live unit test in plan98: https://github.com/tylerchilds/plan98/blob/plan98/client/public/tests.js