Fix a build failure on Apple Clang 17.0.0 related to the distance calculation in js_string_convert_pos #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code previously called abs() on the result of an unsigned subtraction (uint32_t).
While the code relied on underflow and implicit casting to int to function, Clang flags this as having no effect (or undefined behavior).
Compiler Error:
Resolution: Replaced the abs() call with a manual conditional subtraction to correctly calculate the distance between the two unsigned positions without relying on implicit casts or underflow.