Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Django 2.0 support #4

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Conversation

Woodzyowl
Copy link

@Woodzyowl Woodzyowl commented Dec 5, 2018

Django 2.0 requires that foreign keys have explicit deletion behavior. This adds in said explicitness. Default behavior is cascade, so I kept it as the default.

@Woodzyowl Woodzyowl requested a review from hwkns December 5, 2018 18:46
@bentleycook
Copy link

LGTM

@mrhwick
Copy link

mrhwick commented Dec 5, 2018

While we're in there, are you sure that we don't want to add signals to mimic the cascade on_delete behavior when the content_object is deleted?

@mrhwick
Copy link

mrhwick commented Dec 5, 2018

Otherwise, LGTM
hellyeahskelly

@Woodzyowl
Copy link
Author

Dammit. I forgot that these two jokers still had access to this repo 😛
And no, I'm not sure about that at all. My only current objective is to eliminate the errors being thrown when I try to run the server. Make it work -> make it work well -> make it work fast

@bstrdsmkr
Copy link

Care to squash those commits?

Otherwise, LGTM =)

@pierce-m
Copy link

pierce-m commented Dec 5, 2018

We squash on merge now

@Woodzyowl Woodzyowl merged commit 55238a2 into bellhops:master Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants