Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Commit

Permalink
Replace slug with slugify
Browse files Browse the repository at this point in the history
Fixes multiple security issues with slug that are caused by the project not being updated for 3 years.

Co-authored-by: James McMahon <JamesMcMahon@users.noreply.github.com>
  • Loading branch information
jeph and JamesMcMahon committed Aug 10, 2018
1 parent 0363642 commit 1a44c4c
Show file tree
Hide file tree
Showing 3 changed files with 835 additions and 843 deletions.
6 changes: 3 additions & 3 deletions dist/sonarqube-scanner-params.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var fs = require('fs')
var path = require('path')
var extend = require('extend')
var readPackage = require('read-pkg').sync
var slug = require('slug')
var slugify = require('slugify')
var log = require('fancy-log')
var get = require('lodash.get')
var uniq = require('lodash.uniq')
Expand All @@ -23,7 +23,7 @@ function defineSonarQubeScannerParams(params, projectBaseDir, sqScannerParamsFro
} catch (e) {
// No 'sonar-project.properties' file - let's add some default values
extend(sonarqubeScannerParams, {
'sonar.projectKey': slug(path.basename(projectBaseDir)),
'sonar.projectKey': slugify(path.basename(projectBaseDir)),
'sonar.projectName': path.basename(projectBaseDir),
'sonar.projectVersion': '0.0.1',
'sonar.projectDescription': 'No description.',
Expand Down Expand Up @@ -73,7 +73,7 @@ function extractInfoFromPackageFile(sonarqubeScannerParams, projectBaseDir) {
})
}
if (pkg) {
sonarqubeScannerParams['sonar.projectKey'] = slug(pkg.name)
sonarqubeScannerParams['sonar.projectKey'] = slugify(pkg.name)
sonarqubeScannerParams['sonar.projectName'] = pkg.name
sonarqubeScannerParams['sonar.projectVersion'] = pkg.version
if (pkg.description) {
Expand Down
Loading

0 comments on commit 1a44c4c

Please sign in to comment.