Fix two small issues #162
Fix two small issues #162
Conversation
Local storage media urls are prefixed with '/', previously only http(s) media preview src were displayed
…nloaded Plus: unit tests for non-existent tweet + invalid tweet ID
|
OK, improved logging and pushed another commit along with unit tests to clarify the edge case where parsing the timestamp was failing (it's actually because the tweet didn't exist). Good catch, thanks! [WIP] tag removed. Should be good to go |
|
Note: this now also includes a fix for the 'download_syndication' method, which was previously failing. Follows the discussion at JustAnotherArchivist/snscrape#996 (comment) |
… token) Plus add in unit tests for token generation + download syndication
pjrobertson
force-pushed
the
small_issues
branch
from
66834e9 to
3546d4a
Compare
| self.assertFalse(response) | ||
|
|
||
| def test_download_malformed_tweetid(self): | ||
| # this tweet does not exist |
There was a problem hiding this comment.
Later on we could parameterise tests to remove some duplication and make it smoother to extend test cases, but I think that might be more of a PyTest way of doing things.
There was a problem hiding this comment.
Yep, I'm switching over to pytest in the unittest PR, we can do that there
|
Thanks Erin! Merged :) |
These are some small issues I came across whilst setting up/testing the project. I will add to this PR if I find any more. For bigger issues/features, I'll create new issues.