Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes certain dependencies, seen as unnecessary or unused.
Removed dependencies
argparse
: built into python by default on>=3.2, we only support python3.10+ so don't need the separate (outdated) package. Ref: https://pypi.org/project/argparse/#descriptionminify_html
: incompatible with python3.13+, although a fix has been merged, it hasn't been released yet. We'll do away with minifying the html as a nice to havetiktok-downloader
: currently broken (the --snaptik option seems to work, but getting '--info' doens't seem to work) - also removes a lot of other things like flask, aiohttp etc.toml
it was unused. If we need a toml parser we can usetomli
- what's used by pytest, autopep8 etc.Other dependencies not removed:
asn1crypto
- used bytimestamping_enricher
but hasn't been updated in 2 years. A possible replacement is asn1webtrix crawler
- part of a bigger refactor/rewrite. As discussed, can we remove this for something more lightweight?tqdm
- used by the telethon archier to show progresstsp_client
- as mentioned elsewhere, it has issues with the latest pyopenssl, and throws warnings on higher versions of python. Currently works, and the dev seems (fairly) responsive. An alternative is rfc3161-client