-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertical spacing and height on Windows, Mac, Linux and in Java apps #48
base: master
Are you sure you want to change the base?
Conversation
Perfect everywhere except Visual Studio, where underline is between pixels
Wanted to move text line down just a little, but this doesn't seem to have done it
This reverts commit 869b863.
I'm not anything to do with this project but I bet attaching some screenshots addressing a couple of problems this fixes might help the project owner out assessing the merge. |
Good point, I'll do that. |
Indeed, I would to like to see some screenshots. Especially under Windows/Java, with dashes and underscores, because these characters tend to disappear depending on their vertical position... Thanks in advance |
I don't know if this was the same thing, but on my (Linux) system 11pt vertical placement and size is quite bad. See attached image. First line is 11pt. Second line is 12pt for comparison. [edit] Running the font through FontSquirrel's ttf generator (to get the non-loopy style set) with Auto-Adjust Vertical Metrics checked seems to fix it. |
Is this issue still valid? |
Tweaked various heights, ascenders, descenders and line gaps to achieve a perfect vertical position of glyphs on Windows, OS X, Linux, including several notable apps like Java applications on Windows/Mac, Atom, Sublime Text, TextMate, Visual Studio, Xcode, Notepad++. In IntelliJ IDEA on Windows set line height to 0.9 for perfect results.