Use ObjectType instead of string

belong-inc · Jan 18, 2024 · b66728d · b66728d
1 parent 2c7677c
commit b66728d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/company.go b/company.go
@@ -10,7 +10,7 @@ const (
 // Reference: https://developers.hubspot.com/docs/api/crm/companies
 type CompanyService interface {
 	Get(companyID string, company interface{}, option *RequestQueryOption) (*ResponseResource, error)
-	GetAssociations(companyID, toObjectType string) (*AssociationsResponse, error)
+	GetAssociations(companyID string, toObjectType ObjectType) (*AssociationsResponse, error)
 	Create(company interface{}) (*ResponseResource, error)
 	Update(companyID string, company interface{}) (*ResponseResource, error)
 	Delete(companyID string) error
@@ -39,9 +39,9 @@ func (s *CompanyServiceOp) Get(companyID string, company interface{}, option *Re
 }
 
 // GetAssociations gets company associations
-func (s *CompanyServiceOp) GetAssociations(companyID, toObjectType string) (*AssociationsResponse, error) {
+func (s *CompanyServiceOp) GetAssociations(companyID string, toObjectType ObjectType) (*AssociationsResponse, error) {
 	result := &AssociationsResponse{}
-	if err := s.client.Get(s.companyPath+"/"+companyID+"/associations/"+toObjectType, result, nil); err != nil {
+	if err := s.client.Get(s.companyPath+"/"+companyID+"/associations/"+string(toObjectType), result, nil); err != nil {
 		return nil, err
 	}
 	return result, nil

diff --git a/company_test.go b/company_test.go
@@ -311,7 +311,7 @@ func TestCompanyServiceOp_GetAssociations(t *testing.T) {
 	}
 	type args struct {
 		companyID    string
-		toObjectType string
+		toObjectType hubspot.ObjectType
 		result       *hubspot.AssociationsResponse
 	}
 	tests := []struct {
@@ -379,7 +379,7 @@ func TestCompanyServiceOp_GetAssociations(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			got, err := tt.fields.client.CRM.Company.GetAssociations(tt.args.companyID, tt.args.toObjectType, tt.args.result)
+			got, err := tt.fields.client.CRM.Company.GetAssociations(tt.args.companyID, tt.args.toObjectType)
 			if !reflect.DeepEqual(tt.wantErr, err) {
 				t.Errorf("Get() error mismatch: want %s got %s", tt.wantErr, err)
 				return