Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated comments to SetAPIKey and replace usages #11

Merged

Conversation

kk-no
Copy link
Member

@kk-no kk-no commented Oct 25, 2022

What to do

  • Add deprecated comment to hubspot.SetAPIKey()
  • With the exception of a few tests, where hubspot.SetAPIKey() is used, it has been replaced with hubspot. SetPrivateAppToken().
  • Added test for private app.

Background

Support for HubSpot private apps available, APIKey deprecated soon.
https://developers.hubspot.com/changelog/upcoming-api-key-sunset

Acceptance criteria

@kk-no kk-no added the enhancement New feature or request label Oct 25, 2022
@kk-no kk-no requested review from ttyfky, hatakoya, sn1w and dys6 October 25, 2022 07:38
@kk-no kk-no self-assigned this Oct 25, 2022
Copy link
Member

@ttyfky ttyfky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kk-no kk-no merged commit f64c04f into main Oct 25, 2022
@kk-no kk-no deleted the feature/deprecate-apikey-and-add-private-app-description branch October 25, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants