Add default properties for company object #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttyfky
reviewed
Nov 9, 2023
Makefile
Outdated
|
|
||
| .PHONY: generate | ||
| generate: ## generate go code (e.g. make generate OBJECT=Contact FILEPATH=contact.csv) | ||
| cd $(TOOLS)/model_generator && go run model_gen.go $(OBJECT) $(FILEPATH) |
There was a problem hiding this comment.
Suggested change
| cd $(TOOLS)/model_generator && go run model_gen.go $(OBJECT) $(FILEPATH) | |
| @cd $(TOOLS)/model_generator && go run model_gen.go $(OBJECT) $(FILEPATH) |
| ### Sample | ||
|
|
||
| ```shell | ||
| $ make generate OBJECT=Contact FILEPATH=contact.csv |
There was a problem hiding this comment.
[opt] maybe good to add sample contact.csv file?
tools/model_generator/model_gen.go
Outdated
| log.Printf("Running with arges: %s\n", os.Args[1:]) // Without command name. | ||
|
|
||
| if len(os.Args) != 3 { | ||
| log.Fatal("Missing required parameters: <objectName> <csvFilePath>") |
There was a problem hiding this comment.
I think cli tool is better not to use log, but use fmt.Print* because log has date&time prefix.
There was a problem hiding this comment.
ttyfky
approved these changes
Nov 13, 2023
joidegn
pushed a commit
to joidegn/go-hubspot
that referenced
this pull request
Dec 13, 2023
…es-for-company-object Add default properties for company object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to do
Background
Followup #23
Acceptance criteria