Visitor Identification module added. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kk-no I have updated the code for the last test fail case, kindly check and approve for test again. |
|
@Sehbaz |
kk-no
reviewed
Dec 28, 2023
…failure issue resolved.
|
@kk-no I have update my code and now that looks far more clean and that should take care of test cases too. I have made PR ready to be review again. Thank you for valuable feedback. |
kk-no
reviewed
Jan 4, 2024
|
@kk-no I have update my code and I have made PR ready to be review again. Thank you for valuable feedback. |
kk-no
approved these changes
Jan 10, 2024
Amazing, thanks for an update! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to do
Added visitor identification API code to the HubspotChat component.
Referenced HubSpot documentation on visitor identification.
Background
The modification was necessary to include the visitor identification API code, which was missing from the library.
The code has been added based on the information available in the HubSpot documentation.
Acceptance criteria
The added code for visitor identification functions as intended.
The linting and testing processes pass successfully during GitHub Actions.