Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wrong int types to string types & update tests #30

Conversation

RomanSter
Copy link

What to do

Refactor wrong int types into string types in the Company struct.

Background

The current hubspot API returns the company response with different field types than what is described in the company struct

Acceptance criteria

@RomanSter RomanSter changed the title refactor wrong int types to string types & update tests Refactor wrong int types to string types & update tests Jan 28, 2024
@kk-no kk-no self-requested a review January 30, 2024 01:05
@kk-no
Copy link
Member

kk-no commented Jan 30, 2024

@RomanSter
Thank you for putting up PR.
This issue has already been reported and a fix has been merged. (#29)
We apologize for the inconvenience, but please wait for the next version, which will be released soon, or use the current main branch.

@kk-no kk-no added the duplicate This issue or pull request already exists label Jan 30, 2024
@kk-no kk-no closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants