Add client of Marketing domain to handle marketing email statistics #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ttyfky
commented
May 13, 2022
ttyfky
commented
- Add marketing service
- Add API of marketing email statistics
- Add legacy package to handle HubSpot API v1 context
- Add doc.go in the root and legacy package
- Add Marketing service - Add API of marketing email statistics - Add legacy package to handle HubSpot API v1 context - Add doc.go in the root and legacy package
ttyfky
commented
May 13, 2022
| @@ -16,7 +17,7 @@ type ExampleContact struct { | |||
| } | |||
|
|
|||
| func ExampleContactServiceOp_Create() { | |||
| cli, _ := hubspot.NewClient(hubspot.SetAPIKey("apikey")) | |||
| cli, _ := hubspot.NewClient(hubspot.SetAPIKey(os.Getenv("API_KEY"))) | |||
There was a problem hiding this comment.
Made apikey to env var to prevent upload real apikey after testing.
- Add Marketing service - Add API of marketing email statistics - Add legacy package to handle HubSpot API v1 context - Add doc.go in the root and legacy package fix: fix test by adding ExportNewMarketing fix: set dmmmy emailID fix: improve struct structure
|
Marketingの分のテストはどのタイミングで足しますか？(後で僕の方で足すでも大丈夫です) |
kk-no
requested changes
May 16, 2022
|
あとついでに README.md の Available list も更新して貰えると助かります。。 |
Co-authored-by: kei <49366645+kk-no@users.noreply.github.com>
ttyfky
commented
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.